cluster/manifest: refactor to 65 byte k1 sigs #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
- Coverage 53.83% 53.68% -0.15%
==========================================
Files 198 198
Lines 26501 26660 +159
==========================================
+ Hits 14267 14313 +46
- Misses 10474 10565 +91
- Partials 1760 1782 +22
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Jul 25, 2023
| if err != nil { | ||
| return errors.Wrap(err, "operator node signature check") | ||
| } | ||
| // verifyNodeSignatures returns true an error if the node signatures field is not correctly |
There was a problem hiding this comment.
Suggested change
| // verifyNodeSignatures returns true an error if the node signatures field is not correctly | |
| // verifyNodeSignatures returns an error if the node signatures field is not correctly |
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // verifyBuilderRegistrations returns an error if populated builder registrations from json are invalid. | ||
| // verifyBuilderRegistrations returns an error if the populated builder registrations are invalid. |
There was a problem hiding this comment.
Suggested change
| // verifyBuilderRegistrations returns an error if the populated builder registrations are invalid. | |
| // verifyBuilderRegistrations returns an error if the builder registrations are not correctly | |
| // populated or otherwise invalid. |
xenowits
approved these changes
Jul 25, 2023
dB2510
reviewed
Jul 25, 2023
Comment on lines
+110
to
+112
| if def.Version != "v1.6.0" && def.Version != "v1.7.0" { | ||
| return errors.New("only v1.6.0 and v1.7.0 cluster definition version supported") | ||
| } |
There was a problem hiding this comment.
why do we need to enforce this?
There was a problem hiding this comment.
because it fails for earlier versions
dB2510
reviewed
Jul 25, 2023
| // Assert Deposit Data | ||
| require.EqualValues(t, val.PubKey, val.DepositData.PubKey) | ||
| require.EqualValues(t, 32_000_000_000, val.DepositData.Amount) | ||
|
|
||
| if !cluster.SupportPregenRegistrations(lock.Version) { |
There was a problem hiding this comment.
can we have similar verification for node signatures as well?
There was a problem hiding this comment.
yes I added that
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor manifest K1 sigs to 65 bytes to align with Ethereum standard.
Also improve cluster lock signature verification.
Also fix DKG to respect v1.6.0 config and not support earlier versions.
category: refactor
ticket: none