Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log/loki: harden client test #2525

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Aug 8, 2023

In case of slow httptest handler execution, don't block and provoke client retransmission, which would result in entriesChan to have two "normal log line" entries.

category: bug
ticket: none

In case of slow `httptest` handler execution, don't block and provoke client retransmission, which would result in entriesChan to have two "normal log line" entries.
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (97b946a) 53.77% compared to head (a164b5d) 53.66%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
- Coverage   53.77%   53.66%   -0.11%     
==========================================
  Files         199      199              
  Lines       26908    26908              
==========================================
- Hits        14469    14441      -28     
- Misses      10645    10663      +18     
- Partials     1794     1804      +10     
Files Changed Coverage Δ
app/log/loki/client.go 68.06% <100.00%> (-12.61%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 10, 2023
@obol-bulldozer obol-bulldozer bot merged commit a247f80 into main Aug 10, 2023
12 of 13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/fix_loki_client_test branch August 10, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants