app/obolapi: create cluster launchpad URL (#2518) #2526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `LaunchpadURLForLock` method, which generates a Launchpad cluster dashboard URL for a given cluster lock. Reference this method in `dkg` and `create cluster` commands so that at the end of those processes, if the user has specified `--publish`, the Launchpad dashboard URL will be printed on the console. category: feature ticket: #2423 Closes #2423.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main-v0.17 #2526 +/- ##
==============================================
+ Coverage 53.54% 53.62% +0.07%
==============================================
Files 198 198
Lines 26756 26786 +30
==============================================
+ Hits 14326 14363 +37
+ Misses 10645 10636 -9
- Partials 1785 1787 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
LaunchpadURLForLockmethod, which generates a Launchpad cluster dashboard URL for a given cluster lock.Reference this method in
dkgandcreate clustercommands so that at the end of those processes, if the user has specified--publish, the Launchpad dashboard URL will be printed on the console.category: feature
ticket: none
cherry-picks: #2518