core: implement duty gater #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
- Coverage 53.76% 53.75% -0.02%
==========================================
Files 199 200 +1
Lines 27068 27101 +33
==========================================
+ Hits 14553 14568 +15
- Misses 10702 10718 +16
- Partials 1813 1815 +2
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Aug 10, 2023
|
|
||
| type dutyGaterOptions struct { | ||
| allowedFutureEpochs int | ||
| nowFunc func() time.Time |
There was a problem hiding this comment.
is nowFunc introduced to make this testable?
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement duty gater that checks whether duties are too far in the future. Next step is to wire it when duties are received over the wire.
category: feature
ticket: #2506