Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update v2 release process #2539

Merged
merged 1 commit into from
Aug 14, 2023
Merged

docs: update v2 release process #2539

merged 1 commit into from
Aug 14, 2023

Conversation

corverroos
Copy link
Contributor

Aligns the release process docs with the v2 doc.

category: docs
ticket: none

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (fa7f89f) 53.73% compared to head (c74d827) 53.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
- Coverage   53.73%   53.71%   -0.02%     
==========================================
  Files         200      200              
  Lines       27101    27101              
==========================================
- Hits        14562    14558       -4     
- Misses      10722    10728       +6     
+ Partials     1817     1815       -2     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- The Charon binary version, `charon version`, are inferred from git tags at build time using `ldflags`, not hardcoded app/version versions.
- Hardcoded Charon app/version is only used to indicate branch type and major version, `v0.X-rc` for release branches or `v0.Y-dev` for main branch.

The process to follow for the next v0.16.0 release is the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can omit using exact numbers like v0.16.0 and replace with v0.X.Y in the following section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that, I think concrete examples is better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it would have been great to mention it as a like For example, ... it might get confusing IMO from reader's perspective

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 14, 2023
@obol-bulldozer obol-bulldozer bot merged commit f5e94bc into main Aug 14, 2023
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/releaseproc branch August 14, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants