Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS #2627

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Oct 9, 2023

Add MIN_EPOCHS_FOR_BLOCK_REQUESTS constant to beaconmock.

Cherry-pick: #2574

category: feature
ticket: none

Add `MIN_EPOCHS_FOR_BLOCK_REQUESTS` constant to beaconmock.

This should fix failing tests here - https://github.com/ObolNetwork/charon/actions/runs/6002406193/job/16278692464?pr=2564.

category: feature 
ticket: none
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4c90ca0) 53.76% compared to head (4d73f85) 53.73%.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.17    #2627      +/-   ##
==============================================
- Coverage       53.76%   53.73%   -0.04%     
==============================================
  Files             198      198              
  Lines           26931    26931              
==============================================
- Hits            14480    14471       -9     
- Misses          10650    10658       +8     
- Partials         1801     1802       +1     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit a9c5450 into main-v0.17 Oct 9, 2023
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/cherrypickstatic branch October 9, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants