Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/genchangelog: force fetch tags #2647

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Oct 18, 2023

Always overwrite tags with whatever is available on remote when generating a changelog.

This has no consequence on tags pushed on the repo, but only on the working copy of the Github action that is executed.

This PR merges 037af68 into main-v0.17.

category: misc
ticket: none

Always overwrite tags with whatever is available on remote
when generating a changelog.

This has no consequence on tags *pushed* on the repo, but only on
the working copy of the Github action that is executed.
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Oct 18, 2023
@dB2510 dB2510 changed the title testutil/genchangelog: force fetch tags (#2644) testutil/genchangelog: force fetch tags Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (98c5f1c) 53.83% compared to head (32e78da) 53.77%.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.17    #2647      +/-   ##
==============================================
- Coverage       53.83%   53.77%   -0.07%     
==============================================
  Files             198      198              
  Lines           26946    26946              
==============================================
- Hits            14506    14489      -17     
- Misses          10637    10651      +14     
- Partials         1803     1806       +3     
Files Coverage Δ
testutil/genchangelog/main.go 14.44% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora added the v0.17.1 label Oct 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gsora gsora merged commit bd4454d into main-v0.17 Oct 19, 2023
12 of 14 checks passed
@gsora gsora deleted the gsora/fix-genchangelog-v0.17 branch October 19, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) v0.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants