github/workflows: split tests #2724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits Go unit tests from integration, compose and fuzz testing. PR CI will always run unit tests. Integration, compose and fuzz testing will be executed once the PR has been merged on a main branch. We still run those tests on release branches (those that begin with `main-v`) because cherry-picking might add incompatibilities.
instead of fiddling with weird github actions params, just run unit tests always since they're very fast to run anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 53.36% 53.23% -0.14%
==========================================
Files 199 199
Lines 27397 27397
==========================================
- Hits 14621 14585 -36
- Misses 10969 11004 +35
- Partials 1807 1808 +1 ☔ View full report in Codecov by Sentry. |
- run integration_tests first - run compose_tests after integration_tests were successful - run fuzz_tests after the previous two were successful
|
Kudos, SonarCloud Quality Gate passed!
|
dB2510
approved these changes
Nov 28, 2023
|
Closing, needs some more thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits Go unit tests from integration, compose and fuzz testing.
PR CI will always run unit tests if said PR contains modifications to Go code.
Integration, compose and fuzz testing will be executed once the PR has been merged on a main branch.
We still run those tests on release branches (those that begin with
main-v) because cherry-picking might add incompatibilities.Also remove
notify_failurestep, since we're not using Discord anymore.category: misc
ticket: none