cmd: alpha test peers tests self #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3052 +/- ##
==========================================
+ Coverage 54.62% 54.89% +0.26%
==========================================
Files 207 209 +2
Lines 29158 29822 +664
==========================================
+ Hits 15928 16371 +443
- Misses 11388 11630 +242
+ Partials 1842 1821 -21 ☔ View full report in Codecov by Sentry. |
gsora
reviewed
Apr 29, 2024
pinebit
approved these changes
Apr 29, 2024
KaloyanTanev
force-pushed
the
kalo/alpha-charon-test-self
branch
from
a86625c
to
661613e
Compare
KaloyanTanev
force-pushed
the
kalo/alpha-charon-test-self
branch
from
661613e
to
88f05ed
Compare
gsora
reviewed
May 8, 2024
|
gsora
approved these changes
May 8, 2024
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alpha peers tests for the TCP node started. Currently only port opened is tested. Test for whether NAT is open is skipped for now as it makes more sense to be added to the peers' tests.
category: feature
ticket: #3076