Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: remove nil context check on test command #3086

Merged
merged 1 commit into from
May 22, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Context nil check is not necessary, as cobra is always checking on their end if the context is nil and if so, assigning background context to it.

category: refactor
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@KaloyanTanev KaloyanTanev changed the title Remove nil context check on test command cmd: remove nil context check on test command May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.78%. Comparing base (ddb95fd) to head (0b17625).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   56.73%   56.78%   +0.05%     
==========================================
  Files         208      208              
  Lines       29113    29104       -9     
==========================================
+ Hits        16516    16528      +12     
+ Misses      10751    10737      -14     
+ Partials     1846     1839       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 22, 2024
@obol-bulldozer obol-bulldozer bot merged commit 280877e into main May 22, 2024
13 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/remove-nil-ctx-check branch May 22, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants