Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: specify exit fetch path #3099

Merged
merged 3 commits into from
May 27, 2024
Merged

cmd: specify exit fetch path #3099

merged 3 commits into from
May 27, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented May 24, 2024

Allow users to specify a path to store fetched signed exit messages into.

category: bug
ticket: none

Allow users to specify a path to store fetched signed exit messages into.
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.78%. Comparing base (210176e) to head (c40672e).

Files Patch % Lines
cmd/exit.go 0.00% 4 Missing ⚠️
cmd/exit_fetch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
- Coverage   56.88%   56.78%   -0.11%     
==========================================
  Files         208      208              
  Lines       29143    29148       +5     
==========================================
- Hits        16579    16552      -27     
- Misses      10728    10755      +27     
- Partials     1836     1841       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/exit.go Outdated Show resolved Hide resolved
gsora and others added 2 commits May 27, 2024 13:30
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 27, 2024
@obol-bulldozer obol-bulldozer bot merged commit dd8f1f0 into main May 27, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/exit-fetch-path-cli branch May 27, 2024 12:32
KaloyanTanev pushed a commit that referenced this pull request Jun 5, 2024
Allow users to specify a path to store fetched signed exit messages into.

category: bug 
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Jun 5, 2024
- #3084
- #3092  
- #3098 
- #3099 
- #3100 
- #3106 
- #3110 
- #3111 
- #3114 
- #3118 

category: misc
ticket: #3103 

closes: #3103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants