Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/validatorapi: metrics for user-agent and content-type #3112

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented May 31, 2024

Added two new metrics to VAPI:

  • core_validatorapi_request_total
  • core_validatorapi_vc_user_agent

These will allows us to track VC's User-Agent strings to determine VC vendor/version implicitly.
And the total number of requests have Content-Type label to track requests' format made by VC.

category: feature
ticket: #3107

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (278bcf7) to head (2e7c2fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
- Coverage   56.82%   56.81%   -0.01%     
==========================================
  Files         208      208              
  Lines       29153    29159       +6     
==========================================
+ Hits        16566    16568       +2     
- Misses      10749    10752       +3     
- Partials     1838     1839       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 3, 2024
@obol-bulldozer obol-bulldozer bot merged commit 3af2f28 into main Jun 3, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/vc-metrics branch June 3, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants