app/eth2wrap: deep validator cache #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a validator cache that caches the complete Validators endpoint request. Short-cut the duty selection for the DV validator set to the known-active, cached list instead: this will reduce the load on the beacon node drastically, since before this change we were calling the BN once every slot. Try to reduce at a minimum upstream BN requests when the VC calls for validator state. All Validators() calls to the upstream BN, if greater than 200 validators, will have an exponential timeout calculated as `(50ms * validator amount)`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
- Coverage 56.82% 56.68% -0.15%
==========================================
Files 208 208
Lines 29153 29234 +81
==========================================
+ Hits 16566 16570 +4
- Misses 10749 10821 +72
- Partials 1838 1843 +5 ☔ View full report in Codecov by Sentry. |
pinebit
reviewed
Jun 4, 2024
Is this done in this PR? I did not find changes implementing this logic. |
…lidators Avoid messing with caller's data.
Add comments explaining what's going on, fetch cached validator as soon as we're in the core flow.
|
pinebit
approved these changes
Jun 4, 2024
KaloyanTanev
approved these changes
Jun 4, 2024
gsora
added
the
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Jun 5, 2024
Implement a validator cache that caches the complete Validators endpoint request. Short-cut the duty selection for the DV validator set to the known-active, cached list instead: this will reduce the load on the beacon node drastically, since before this change we were calling the BN once every slot. Try to reduce at a minimum upstream BN requests when the VC calls for validator state. All Validators() calls to the upstream BN, if greater than 200 validators, will have an exponential timeout calculated as `(50ms * validator amount)`. category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a validator cache that caches the complete Validators endpoint request.
Short-cut the duty selection for the DV validator set to the known-active, cached list instead: this will reduce the load on the beacon node drastically, since before this change we were calling the BN once every slot.
Try to reduce at a minimum upstream BN requests when the VC calls for validator state.
All Validators() calls to the upstream BN, if greater than 200 validators, will have an exponential timeout calculated as
(50ms * validator amount).category: feature
ticket: none