Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: composite GitHub actions #3119

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Jun 5, 2024

Reuse setup-go step throughout the pipeline. This way it would be easier to update go version in the future and we ensure consistency. If this approach is mutually agreed to be better, we can apply it to other parts of the pipeline as well.

category: refactor
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Jun 5, 2024
@KaloyanTanev KaloyanTanev marked this pull request as draft June 5, 2024 12:00
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (e0aece0) to head (b61e9ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
- Coverage   56.82%   56.76%   -0.06%     
==========================================
  Files         208      208              
  Lines       29276    29276              
==========================================
- Hits        16635    16618      -17     
- Misses      10803    10817      +14     
- Partials     1838     1841       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@KaloyanTanev KaloyanTanev marked this pull request as ready for review June 5, 2024 12:18
Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks better than before.

@gsora
Copy link
Collaborator

gsora commented Jun 5, 2024

This PR is a blessing for when we have to update to a newer Go version!

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 5, 2024
@obol-bulldozer obol-bulldozer bot merged commit 43979af into main Jun 5, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/composite-github-actions branch June 5, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants