eth2wrap: initialize fork version on lazy #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the `lazy` interface to set the Eth2CL fork version, initialize it immediately *before* returning it as a `lazy`. Fixes exits through VCs.
gsora
force-pushed
the
gsora/fix-vc-exits-capella-domain
branch
from
dc40d06
to
c2e6f0b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
+ Coverage 56.73% 56.82% +0.09%
==========================================
Files 208 208
Lines 29308 29314 +6
==========================================
+ Hits 16628 16658 +30
+ Misses 10838 10817 -21
+ Partials 1842 1839 -3 ☔ View full report in Codecov by Sentry. |
gsora
added
merge when ready
|
KaloyanTanev
approved these changes
Jun 11, 2024
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Jun 11, 2024
Instead of relying on the `lazy` interface to set the Eth2CL fork version, initialize it immediately *before* returning it as a `lazy`. Fixes exits through VCs. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the
lazyinterface to set the Eth2CL fork version, initialize it immediately before returning it as alazy.Fixes exits through VCs.
category: bug
ticket: none