Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cherrypick for v1.0.0-rc5 #3134

Merged
merged 3 commits into from
Jun 11, 2024
Merged

*: cherrypick for v1.0.0-rc5 #3134

merged 3 commits into from
Jun 11, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jun 11, 2024

gsora and others added 3 commits June 11, 2024 18:17
Users might DKG large clusters, containing high amounts of validators (like 2.5K).

With large validator amounts, the DKG process needs either more time or more power (CPU, network bandwidth) to complete.

Allow users to specify a custom timeout for the entire process, allowing large DKGs on normal-powered machines.

Tested 2.5K validator DKGs locally with 0.relay.obol.tech, 10 minutes timeout: completed with no issues.

category: feature
ticket: none
Instead of relying on the `lazy` interface to set the Eth2CL fork version, initialize it immediately *before* returning it as a `lazy`.

Fixes exits through VCs.

category: bug
ticket: none
Revise thresholds for pinging and BN peers.

category: misc
ticket: none
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Jun 11, 2024
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 30.55556% with 50 lines in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (af2bbf7) to head (a02351f).

Files Patch % Lines
cluster/manifestpb/v1/manifest.pb.go 0.00% 9 Missing ⚠️
dkg/dkgpb/v1/frost.pb.go 0.00% 7 Missing ⚠️
core/corepb/v1/consensus.pb.go 0.00% 5 Missing ⚠️
core/corepb/v1/priority.pb.go 0.00% 5 Missing ⚠️
cmd/testpeers.go 0.00% 4 Missing ⚠️
core/corepb/v1/core.pb.go 0.00% 4 Missing ⚠️
app/log/loki/lokipb/v1/loki.pb.go 0.00% 3 Missing ⚠️
dkg/dkgpb/v1/bcast.pb.go 0.00% 3 Missing ⚠️
cmd/dkg.go 0.00% 2 Missing ⚠️
cmd/testbeacon.go 0.00% 0 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##           main-v1.0    #3134      +/-   ##
=============================================
+ Coverage      56.36%   56.44%   +0.08%     
=============================================
  Files            208      208              
  Lines          29199    29205       +6     
=============================================
+ Hits           16458    16485      +27     
+ Misses         10920    10898      -22     
- Partials        1821     1822       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obol-bulldozer obol-bulldozer bot merged commit a862a0b into main-v1.0 Jun 11, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/v1.0.0-rc5 branch June 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants