Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cherry-pick for v1.0.0-rc7 #3154

Merged
merged 3 commits into from
Jun 25, 2024
Merged

*: cherry-pick for v1.0.0-rc7 #3154

merged 3 commits into from
Jun 25, 2024

Conversation

Shortcut `/eth/v2/beacon/blinded_blocks/submit_blinded_block_v2` to use newer proposals rather than blinded block proposals.

category: bug
ticket: none
Do the same type casting we do in core/bcast to switch on the type of block proposal.

Add a test to check for this property.

category: bug
ticket: none
Always recover when dealing with malformed proposals, and log some context to aid debugging.

category: refactor
ticket: none
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Jun 25, 2024
@gsora gsora changed the title core/validatorapi: convert blinded to full proposal (#3144) *: cherry-pick for v1.0.0-rc7 Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (3222fdd) to head (fb6e52c).

Files Patch % Lines
core/tracker/inclusion.go 62.50% 12 Missing and 3 partials ⚠️
core/bcast/bcast.go 62.50% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           main-v1.0    #3154      +/-   ##
=============================================
+ Coverage      56.39%   56.47%   +0.07%     
=============================================
  Files            208      208              
  Lines          29205    29251      +46     
=============================================
+ Hits           16471    16519      +48     
+ Misses         10912    10908       -4     
- Partials        1822     1824       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obol-bulldozer obol-bulldozer bot merged commit 84fe2ab into main-v1.0 Jun 25, 2024
13 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/v1.0.0-rc7 branch June 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants