core/validatorapi: check proposal data against consensus one #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of blindly accepting VC proposal data, check it for integrity against what we have in DutyDB: if they differ, stop the process.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 57.63% 57.70% +0.06%
==========================================
Files 211 211
Lines 30480 30718 +238
==========================================
+ Hits 17568 17726 +158
- Misses 11016 11077 +61
- Partials 1896 1915 +19 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Sep 18, 2024
|
Tested in kurtosis, seems to be working well. |
Alsop update beaconmock default block from Capella to Deneb.
…haron into gsora/vapi-check-prop-data
|
gsora
added
the
merge when ready
pinebit
pushed a commit
that referenced
this pull request
Oct 18, 2024
Instead of blindly accepting VC proposal data, check it for integrity against what we have in DutyDB: if they differ, stop the process. category: refactor ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of blindly accepting VC proposal data, check it for integrity against what we have in DutyDB: if they differ, stop the process.
category: refactor
ticket: none