Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit: add custom testnet flags for exits #3317

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Add testnet flags for exits. We have testnet for other CLI commands, but not for the exits. Required so we can easily test with Kurtosis.

Fix a test in cmd/createcluster_internal_test.go as well. Add custom test dir for it.

category: misc
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 6.55738% with 57 lines in your changes missing coverage. Please review.

Project coverage is 58.66%. Comparing base (4bbb36e) to head (2ebe6f7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/exit.go 0.00% 20 Missing ⚠️
cmd/exit_broadcast.go 9.09% 9 Missing and 1 partial ⚠️
cmd/exit_fetch.go 10.00% 8 Missing and 1 partial ⚠️
cmd/exit_list.go 10.00% 8 Missing and 1 partial ⚠️
cmd/exit_sign.go 10.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
- Coverage   58.77%   58.66%   -0.12%     
==========================================
  Files         210      210              
  Lines       30213    30274      +61     
==========================================
+ Hits        17758    17759       +1     
- Misses      10564    10619      +55     
- Partials     1891     1896       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 15, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

@obol-bulldozer obol-bulldozer bot merged commit 7c0bcce into main Oct 15, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/add-testnet-to-exits branch October 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants