-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: consensus abstraction #3327
*: consensus abstraction #3327
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
+ Coverage 58.68% 58.82% +0.14%
==========================================
Files 210 216 +6
Lines 30290 30449 +159
==========================================
+ Hits 17777 17913 +136
- Misses 10621 10636 +15
- Partials 1892 1900 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, generally looks great
Added @OisinKyne to review at least:
|
Quality Gate passedIssues Measures |
Summary of changes:
ConsensusController
interface.consensus
package with increased test coverage.cluster run --consensus-protocol=xyz
flag.docs/consensus.md
category: feature
ticket: #3304