Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/eth2wrap: fallback beacon nodes #3342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

app/eth2wrap: fallback beacon nodes #3342

wants to merge 1 commit into from

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Oct 15, 2024

Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes.

When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that.

If no fallback BNs is specified, return the original error.

If the fallback BN call fails, return fallback error instead.

This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later.

category: feature
ticket: #3328

Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes.

When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that.

If no fallback BNs is specified, return the original error.

If the fallback BN call fails, return fallback error instead.

This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later.
Copy link

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 31.86992% with 419 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (4bbb36e) to head (1138ab3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
app/eth2wrap/eth2wrap_gen.go 15.58% 388 Missing and 2 partials ⚠️
app/eth2wrap/multi.go 78.82% 18 Missing ⚠️
app/eth2wrap/eth2wrap.go 75.55% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   58.77%   58.27%   -0.51%     
==========================================
  Files         210      211       +1     
  Lines       30213    30699     +486     
==========================================
+ Hits        17758    17889     +131     
- Misses      10564    10915     +351     
- Partials     1891     1895       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora requested review from pinebit and KaloyanTanev October 29, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants