app: eth2wrap latency logging #3417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
- Coverage 57.36% 57.28% -0.09%
==========================================
Files 217 217
Lines 31977 31977
==========================================
- Hits 18345 18319 -26
- Misses 11744 11766 +22
- Partials 1888 1892 +4 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
force-pushed
the
kalo/eth2wrap-latency-logging
branch
from
67e4662 to
2cd6fe0
Compare
pinebit
reviewed
Dec 12, 2024
|
gsora
approved these changes
Dec 17, 2024
pinebit
reviewed
Dec 17, 2024
| log.Debug(ctx, "Beacon node call finished", z.Str("endpoint", endpoint)) | ||
| // If BN call took more than 1 second, send WARN log | ||
| if rtt > time.Second { | ||
| log.Warn(ctx, "Beacon node call took longer than expected", nil, z.Str("endpoint", endpoint), z.Str("rtt", rtt.String())) |
There was a problem hiding this comment.
I suggest we see this warning even when enableLogs is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logs for some beacon node calls RTT. In order to help tracking issues with underperforming beacon nodes, caused either by slow infrastructure/networking or issues from the beacon node itself.
Currently logs have been added only on the calls for:
I'm open to including more endpoints.
Fixing linter on one place.
category: feature
ticket: none