-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: arm64 releases #3493
base: main
Are you sure you want to change the base?
ci: arm64 releases #3493
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
==========================================
- Coverage 57.44% 57.40% -0.05%
==========================================
Files 217 217
Lines 32245 32245
==========================================
- Hits 18524 18511 -13
- Misses 11814 11826 +12
- Partials 1907 1908 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using goreleaser
, I find it easier to maintain and straight forward? We've discussed it before, but we had some incompatibilities with it, which now are fixed afaik.
runs: | ||
using: 'composite' | ||
steps: | ||
- name: Setup go | ||
id: setup-go | ||
uses: actions/setup-go@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are on it, we can probably bump this version as well
uses: actions/setup-go@v4 | |
uses: actions/setup-go@v5 |
sha256sum charon-${{ env.RELEASE_VERSION }}-linux-arm64.tar.gz >> checksums.txt | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/upload-artifact@v3 | |
uses: actions/upload-artifact@v4 |
|
||
- name: Attach to GitHub Release | ||
if: github.event.workflow_run.conclusion == 'success' | ||
uses: softprops/action-gh-release@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: softprops/action-gh-release@v1 | |
uses: softprops/action-gh-release@v2 |
This workflow handles the automated build and release process for Charon binaries. Key features include:
Cross-Platform Build Support:
Version Management:
Release Artifacts:
Release Process:
The workflow ensures reliable, reproducible builds while maintaining a clear and organized release process.
category: fixbuild
ticket: none