Allow to advertise p2p service via NodePort or LodeBalancer, allow to use secrets from elsewhere #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matilote
commented
Jul 29, 2024
matilote
commented
- added separate p2p service to expose ports on TCP/UDP protocols
- allow to expose p2p service via NodePort or LodeBalancer in addition to ClusterIp
- set externalIp dynamically by using init container
- make usage of secrets conditional to allow fetching them through init containers or externalSecrets
- make readiness and liveness probes conditional
fix: service monitor port for charon
feat: add prefix to prometheus resources
fix: config map reference
Feat/node port charon
use single line appropproach
aly-obol
previously approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.