Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serious grammar and spelling errors in docs #431

Closed
wants to merge 5 commits into from

Conversation

antews
Copy link

@antews antews commented Oct 15, 2024

Summary

In reviewing the project documentation, I have identified and corrected several errors and typos that were inadvertently made during its creation. These errors can lead to confusion or misunderstanding.

Details

Ensuring clarity and accuracy in documentation is critical for both users and developers.

Closes #432

ticket:
#432

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for obol-docs ready!

Name Link
🔨 Latest commit fdd9056
🔍 Latest deploy log https://app.netlify.com/sites/obol-docs/deploys/6720cf63cb74e00008509618
😎 Deploy Preview https://deploy-preview-431--obol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/advanced/quickstart-builder-api.mdx Outdated Show resolved Hide resolved
docs/advanced/quickstart-builder-api.mdx Outdated Show resolved Hide resolved
@OisinKyne
Copy link
Contributor

Hey i can't merge this due to conflicts, can you figure out does it need a rebase or what is up with it? :)

Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@OisinKyne OisinKyne mentioned this pull request Oct 28, 2024
Copy link

sonarcloud bot commented Oct 29, 2024

@antews
Copy link
Author

antews commented Oct 29, 2024

Hey i can't merge this due to conflicts, can you figure out does it need a rebase or what is up with it? :)

Hi! @OisinKyne I've rebased and resolved all conflicts, now PR is ready for merge! Thanks!

@antews
Copy link
Author

antews commented Oct 29, 2024

Hi! @OisinKyne I've rebased and resolved all conflicts, now PR is ready for merge! Thanks!

Hi! @OisinKyne I've rebased and resolved all conflicts, now PR is ready for merge! Thanks!

@OisinKyne
Copy link
Contributor

Hey apologies. I was in a hurry to get these changes in before I tagged the next release such that they would show up outside the next section, so i implemented them in another PR. This PR just has two extra newlines left. Appreciate the follow up and rebase though, sorry for not coming back to this!

@OisinKyne OisinKyne closed this Oct 29, 2024
@antews
Copy link
Author

antews commented Oct 29, 2024

Hey apologies. I was in a hurry to get these changes in before I tagged the next release such that they would show up outside the next section, so i implemented them in another PR. This PR just has two extra newlines left. Appreciate the follow up and rebase though, sorry for not coming back to this!

Now I'am won't be in the contributor list, right? @OisinKyne

@antews
Copy link
Author

antews commented Oct 30, 2024

Hey apologies. I was in a hurry to get these changes in before I tagged the next release such that they would show up outside the next section, so i implemented them in another PR. This PR just has two extra newlines left. Appreciate the follow up and rebase though, sorry for not coming back to this!

?

@slugmann321
Copy link
Contributor

@antews please only contribute if you actually want to see changes, not to get on a list. There is no "list" and being a contributor will not advantage you in any way. Thank you.

@antews antews deleted the errors branch November 3, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: serious grammar and spelling errors
3 participants