adds blocked page #95
Conversation
✅ Deploy Preview for obol-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Not really clear what the termly thing is, I don't really want a tracker like this (at least its not on the DVL, site is a bit less bad)
Is it not enough to just always bounce people from *.launchpad.obol.tech to https://obol.tech/blocked every time they hit the launchpad? I don't understand what we need to use termly for here.
| useEffect(() => { | ||
| if (router.pathname !== "/blocked") { | ||
| const script = document.createElement("script"); | ||
| script.src = "https://app.termly.io/embed.min.js"; |
There was a problem hiding this comment.
What's this and why do we need it?
There was a problem hiding this comment.
Hi, @OisinKyne I just saw that comment, and for some reason didn’t get that notification, this is actually the opposite, I’m not adding the termly script when it goes to the blocked page. that means, that the page it will not raise the cookies banner
There was a problem hiding this comment.
Okay fair enough. If this was dvl I'd maybe push for not using a third party tracker, but for site its fine, its just a landing page for people that bounce off.
Summary
Details
How to test it
Screenshots
ticket: #000