chore: remove deprecated speckit/OMC/beads toolchain artifacts#91
chore: remove deprecated speckit/OMC/beads toolchain artifacts#91
Conversation
Delete 15 speckit skill directories (.claude/skills/speckit-*), the OMC optimization plan, skill-chains.json, and .specify/scripts and .specify/templates directories. Specwright plugin replaces all speckit skills: - specify/clarify → /sw-design - plan/tasks → /sw-plan - implement → /sw-build - test-review/wiring-check/merge-check → /sw-verify - pr → /sw-ship Part of: toolchain-cleanup 🤖 Generated with Claude Code <noreply@anthropic.com>
…right Replace all /speckit.* command references with specwright equivalents: - /speckit.implement → /sw-build - /speckit.test-review → /sw-verify - /speckit.wiring-check → /sw-verify - /speckit.merge-check → /sw-verify - /speckit.pr → /sw-ship - /speckit.specify → /sw-design - /speckit.plan → /sw-plan Update session-recover and pre-pr-gate scripts to reference specwright commands in phase hints and error messages. Part of: toolchain-cleanup 🤖 Generated with Claude Code <noreply@anthropic.com>
- Rewrite skill-invocation.md: remove OMC Agent Integration section, add Specwright Workflow table, remove speckit skill chains - Update quality-escalation.md, test-organization.md, epic-recovery.md: replace /speckit.* and bd CLI refs with specwright equivalents - Update RULES_INDEX.md: replace bd stats with /sw-audit - Update plugin-quality and contract-stability agent descriptions - Update skills README and tech-debt-review SKILL.md - Full rewrite of workflow-quickref.md: remove stale agent tables (6 deleted agents), bd CLI refs, and all speckit commands - Clean .specify/memory/constitution.md template references - Fix test-debt-analyzer.md missing tools field (pre-existing) Part of: toolchain-cleanup 🤖 Generated with Claude Code <noreply@anthropic.com>
- Mark ADR-0042 (Linear + Beads Traceability) as Superseded - Update ADR index and ADR-0046 cross-reference - Remove .omc/research/ path references from ingestion plugin specs - Remove /speckit-taskstolinear and /speckit-analyze refs from specs - Remove "beads" from .specwright/config.json push provider and checks Part of: toolchain-cleanup 🤖 Generated with Claude Code <noreply@anthropic.com>
🤖 Generated with Claude Code <noreply@anthropic.com>
|
Claude finished @MacAttak's task —— View job Security Review of PR #91 ✅Completed comprehensive security analysis of all 53 changed files focusing on injection vulnerabilities, authentication/authorization, data exposure, cryptographic issues, input validation, and dangerous constructs. Security Review Checklist
Security Findings: NO VULNERABILITIES DETECTED✅ CLEAN - No security issues found in this PRThis PR consists primarily of cleanup activities (removing deprecated toolchain files and updating documentation references) with minimal security impact. Detailed Analysis:1. Configuration Files ✅ SECURE
2. Shell Scripts ✅ SECURE
3. Documentation Changes ✅ SECURE
4. File Deletions ✅ POSITIVE SECURITY IMPACT
5. Cross-File Security Patterns ✅ EXCELLENT
Security Best Practices Observed:
Remediation Required: NONEThis PR demonstrates excellent security hygiene and actually improves the overall security posture by reducing the codebase size and eliminating unused components. |
Greptile SummaryLarge housekeeping PR that removes the deprecated speckit/OMC/beads toolchain and replaces it with Specwright (
Confidence Score: 3/5
Important Files Changed
Flowchartflowchart TD
A["/sw-design"] --> B["/sw-plan"]
B --> C["/sw-build"]
C --> D["/sw-verify"]
D -->|gates pass| E["/sw-ship"]
D -->|findings found| F["Fix findings"]
F --> D
E --> G["PR Created"]
subgraph "Quality Gates (gate-*)"
D1["gate-build"]
D2["gate-tests"]
D3["gate-security"]
D4["gate-wiring"]
D5["gate-spec"]
end
D --> D1 & D2 & D3 & D4 & D5
subgraph "State Files"
S1[".specwright/state/workflow.json"]
S2[".specwright/config.json"]
end
D1 & D2 & D3 & D4 & D5 -->|results written to| S1
S2 -->|gate config| D
subgraph "Pre-PR Hook"
H["scripts/pre-pr-gate"]
H2[".agent/quality-state.json ⚠️ legacy path"]
end
E -->|triggers| H
H -->|reads| H2
H2 -.->|should read| S1
Last reviewed commit: 50c0ff5 |
Additional Comments (3)
Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/pre-pr-gate
Line: 63:63
Comment:
**Unused variable declaration**
`integration_check_passed` is declared on line 63 but never assigned or used — it appears to be a leftover from before `wiring_check_passed` replaced it. The `local` declaration serves no purpose and may confuse future readers.
```suggestion
local wiring_check_passed
```
How can I resolve this? If you propose a fix, please make it concise.
The script reads quality state from If Specwright's Prompt To Fix With AIThis is a comment left during a code review.
Path: scripts/pre-pr-gate
Line: 20:20
Comment:
**State file still reads legacy `.agent/` path**
The script reads quality state from `.agent/quality-state.json` with legacy field names (`test_review_passed`, `wiring_check_passed`, `merge_check_passed`). However, the PR description and `workflow-quickref.md` indicate quality gate results are now tracked in `.specwright/state/workflow.json`. The error messages were updated to say "Run `/sw-verify`" but the actual state-checking logic still looks for the old file and old fields.
If Specwright's `/sw-verify` writes gate results to `.specwright/state/workflow.json` (as shown in that file's `gates` section) rather than `.agent/quality-state.json`, this script will always fall through to "No quality state file found" and proceed with basic checks only — silently bypassing the quality gate.
How can I resolve this? If you propose a fix, please make it concise.
This line still references Prompt To Fix With AIThis is a comment left during a code review.
Path: .claude/rules/quality-escalation.md
Line: 310:310
Comment:
**Missed `bd` reference**
This line still references `bd update`, a command from the deprecated toolchain. Other files in this PR have been updated to remove `bd` references — this one was missed.
```suggestion
3. **Record in session notes** via notepad or session memory
```
How can I resolve this? If you propose a fix, please make it concise. |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Remove unused `integration_check_passed` declaration (scripts/pre-pr-gate:63) - Migrate state file from `.agent/quality-state.json` to `.specwright/state/workflow.json` and update gate-checking logic to read specwright gate structure - Replace `bd update` with neutral language in quality-escalation.md 🤖 Generated with Claude Code <noreply@anthropic.com>
|
All three review findings addressed in
|
Summary
/sw-design,/sw-plan,/sw-build,/sw-verify,/sw-ship)Acceptance Criteria
d14c276— 15 dirs, 5354 lines deletedd14c276— optimization-plan.md, skill-chains.json, .specify/scripts/, .specify/templates/f2d58d3— Quick Start, Phases, Workflow sections updatedf2d58d3— session-recover + pre-pr-gate, syntax validatedb944185— 9 files across .claude/rules/, agents/, skills/f2d58d3— 8 speckit refs replacedf2d58d3— 3 occurrences via replace_allb944185— removed 6 stale agents, all bd/speckit refs938265a— status + index + ADR-0046 cross-ref938265a— beads-sync removed from .specwright/config.json938265a— 4f research + tasks, 13 analysis, 4e tasksb944185— .specify/templates/ ref in constitution.mdGate Results
gate-wiring INFO: 8 orphaned permission entries in
.claude/settings.local.json(gitignored) referenced deleted scripts — cleaned up locally.Test plan
grep -r '/speckit\.' CLAUDE.md AGENTS.md TESTING.md scripts/ .claude/rules/ .claude/agents/returns zero matchesgrep -r 'oh-my-claudecode' .claude/returns zero matchesgrep -r 'beads-sync' .specwright/config.jsonreturns zero matches🤖 Generated with Claude Code