fix(hooks): use plugin root path and deterministic stop script#34
Merged
fix(hooks): use plugin root path and deterministic stop script#34
Conversation
SessionStart used a relative path that resolved against project CWD
instead of the plugin root, causing MODULE_NOT_FOUND in every non-
Specwright project. Stop hook used type:prompt which produced non-
deterministic JSON from LLM output, failing validation intermittently.
- SessionStart: node ./hooks/... → node ${CLAUDE_PLUGIN_ROOT}/hooks/...
- Stop: type:prompt → type:command with new session-stop.mjs script
- session-stop.mjs reads workflow.json directly, outputs clean JSON
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${CLAUDE_PLUGIN_ROOT}instead of relative CWD (caused MODULE_NOT_FOUND in every non-Specwright project)type: "prompt") with a deterministic Node.js script (type: "command") that outputs clean JSONAcceptance Criteria
hooks/hooks.json:8— uses${CLAUDE_PLUGIN_ROOT}/hooks/session-start.mjshooks/hooks.json:18—type: "command",hooks/session-stop.mjs:26—console.log(JSON.stringify(...))hooks/session-stop.mjs:13-16(missing file),:33-35(parse error),:23-29(active work)Gate Results
Evidence
.specwright/work/fix-hooks-reliability/evidence/spec-compliance.mdWork unit:
fix-hooks-reliability| Intensity: quick🤖 Generated with Claude Code