Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding installation instructions to documentation #1403

Merged
merged 15 commits into from
Aug 7, 2023

Conversation

erikvansebille
Copy link
Member

Now that the tutorials are all on readthedocs, it makes sense to also move the installation instructions there. In this PR, I created an RST version of the installation instructions at https://oceanparcels.org/#installing, and also considerably cleaned them up / simplified them

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments.

Sidenote, @erikvansebille do you use sphinx-autobuild docs docs/_build for your docs local development? I'm getting an infinite rendering loop on my end, and just wondering if that's high enough priority for me to patch.

docs/index.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
erikvansebille and others added 6 commits July 28, 2023 08:37
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
@erikvansebille
Copy link
Member Author

Tanks for these comments, @VeckoTheGecko! Really useful! Especially the fact that conda activate now works all platforms makes the instructions cleaner. Shows that we based these instructions on a very old condo version...

Sidenote, @erikvansebille do you use sphinx-autobuild docs docs/_build for your docs local development? I'm getting an infinite rendering loop on my end, and just wondering if that's high enough priority for me to patch.

No, I don't use sphinx-auto build myself. Am doing manual building for now.

docs/contributing.md Outdated Show resolved Hide resolved
VeckoTheGecko and others added 5 commits July 30, 2023 07:10
Removing suggestion to change $PYTHONPATH
Removing the 'double-block' for code in a list, that seems to be a bug in sphinx-docs? Now also more control on the numbering of items

Also updating some of the texts
erikvansebille and others added 2 commits August 3, 2023 09:11
Fixed ordering. May have been misinterpreted before as "cd into the `parcels` folder in the `parcels` repo", as opposed to "cd into the `parcels` repo"
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small edit, but LGTM otherwise!

@erikvansebille erikvansebille merged commit 0f39670 into master Aug 7, 2023
10 checks passed
@erikvansebille erikvansebille deleted the installation_on_docs branch August 7, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants