Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Azure Container App template #1568

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Oct 23, 2024


Background

Microsoft changed the behavior of the Get-AzContainerApp cmdlet, it used to return null when searching for a specific Container App and it didn't exist. It now throws an error causing the template to fail.

Results

Template will now perform a search of all container apps within the specified Resource Group. If the results are null, the $containerApp variable is assigned $null. If something is returned, it does a Where-Object operation and will either return the desired Container App or return null if it doesn't exist within the collection.

Before

The step template would fail when the Container App didn't exist.

After

The template no longer errors and will function as desired.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

Copy link
Contributor

@benPearce1 benPearce1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benPearce1 benPearce1 merged commit 11d726b into master Oct 25, 2024
3 checks passed
@benPearce1 benPearce1 deleted the bug-azure-deploy-containerapp branch October 25, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants