Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Trust Certificate option #1577

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Added Trust Certificate option #1577

merged 2 commits into from
Dec 12, 2024

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Dec 12, 2024


Background

The quickstart guide for Conjur has been updated and now uses self-signed certificates. The Samples example began to fail, along with fixing the Sample, the template was updated to allow to trust the server certificate. This will allow users with internal Certificate Authorities to work along with anyone using self-signed certificates

Results

Calls to SSL enabled Conjur servers that use self-signed certificates will function.

Before

The rest method calls would fail as it could not determine the CA certificate.

After

Calls are now successful which also allows the example in Samples to function properly.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

Copy link
Contributor

@harrisonmeister harrisonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamoctoclose adamoctoclose merged commit e6030ac into master Dec 12, 2024
2 checks passed
@adamoctoclose adamoctoclose deleted the update-conjur branch December 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants