fix: Standardise namespace access and lookup #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardises namespace access and lookup. Now, namespaces are cached using an expirable LRU cache (only 1 entry, but easier than managing the expiry logic ourselves) if being looked up. If namespaces have been set on startup, the cache is never instantiated.
Namespaces are obtained during planning, and then stored in the plan, and not re-obtained from the cache. This allows the
validationstep to be more idempotent.We also no longer default to creating SAs in the
defaultnamespace, and instead, return an error which is written to the WSA to let users know that there is an issue discovering/using namespaces.