feat: response schema validation against OpenAPI spec#89
Merged
mikolajbadyl merged 3 commits intomainfrom Feb 28, 2026
Merged
Conversation
Code Review SummaryStatus: 3 Suggestions Found | Recommendation: Merge Overview
Issue Details (click to expand)SUGGESTION
Resolved ItemsThe following issues from the previous review have been addressed:
Files Reviewed (8 files)
Code Quality: The implementation is solid and follows existing codebase patterns. Schema validation logic is correctly integrated into the test execution flow. The new code adds valuable functionality for validating API responses against OpenAPI schemas. All new functions now have adequate test coverage. Recommendation: Ready to merge. The three suggestions are minor enhancements that don't block the merge. |
…eSchema, resolveRefs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates response bodies against the OpenAPI schema after each test — not just the HTTP status code. A test can now pass on status but fail on schema mismatch (wrong types, missing required fields, etc.).
parser.go— extracts response schemas from OpenAPI spec, resolves$refreferencesschema_validator.go— new validator (type, required, nullable, arrays), no external depshandlers.go— runs validation after each test, path template matching (/users/{id}), fixed nil panic on existing project loadupdate_tests.go— shows⚠with schema errors in TUI, sets exit code 1 on mismatchchat.go— agent reports schema errors, PDF report only on explicit user request