fix: handle string body in test executor to avoid double JSON encoding#90
Merged
mikolajbadyl merged 2 commits intomainfrom Feb 28, 2026
Merged
fix: handle string body in test executor to avoid double JSON encoding#90mikolajbadyl merged 2 commits intomainfrom
mikolajbadyl merged 2 commits intomainfrom
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Analysis:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent sends request bodies as JSON strings (per the
ExecuteTestGrouptool schema:"type": ["string", "null"]). The executor was callingjson.Marshalon that string, which double-encoded it — the server received"{\name\:\"Alice\"}"instead of{"name":"Alice"}, causing all POST/PUT/PATCH requests to fail with 400.Fix: if
bodyis already a string, pass it directly to the request reader instead of marshaling it again.