fix: enforce expected_status in test execution pipeline#91
Merged
mikolajbadyl merged 2 commits intomainfrom Feb 28, 2026
Merged
fix: enforce expected_status in test execution pipeline#91mikolajbadyl merged 2 commits intomainfrom
mikolajbadyl merged 2 commits intomainfrom
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Review NotesThis PR introduces a required
The flow is consistent: validation prevents tests without expected_status from proceeding, and the agent is informed to re-call with the correct field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent was always comparing results against status 200, even when testing error cases (400, 404).
agent.go— local test plan generator now includesexpected_statusin the JSON format and knows which status codes to use per method/scenariochat.go— addedexpected_statustoExecuteTestGrouptool schema (required field) with clear instructionsupdate_tests.go—expected_statusis now included in test cases returned to the agent afterGenerateTestPlan