fix: weasyprint timeout and export auth as env var placeholders#94
Merged
mikolajbadyl merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
Member
mikolajbadyl
commented
Feb 28, 2026
- `weasyprint` now runs with a 30s timeout — hangs no longer freeze the CLI
- Auth credentials in exported files (curl/pytest/postman) replaced with env var placeholders (`$AUTH_TOKEN`, `os.environ["AUTH_TOKEN"]`, `{{AUTH_TOKEN}}`)
- OpenAPI `security` field now parsed per-endpoint and globally — `requires_auth` correctly set from spec
- Export auth config falls back to CLI `--auth`/`--token` flags when no saved project config exists
- `Content-Type: application/json` omitted from curl/pytest exports when request has no body
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (6 files)
Summary: The PR introduces good improvements - security requirement parsing in OpenAPI specs, timeout handling for PDF generation, and environment variable-based authentication for exported tests. However, there are 4 critical Go syntax errors in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.