Don't trust hasStackUsageOutput/hasOptOutput - they can be true f…

…or compilations that failed and really have no `stackUsageOutput`/`optOutput`
OfekShilon · May 11, 2024 · 3ccb801 · 3ccb801
1 parent 0741ec2
commit 3ccb801
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/static/panes/opt-view.ts b/static/panes/opt-view.ts
@@ -124,7 +124,8 @@ export class Opt extends MonacoPane<monaco.editor.IStandaloneCodeEditor, OptStat
         }
 
         this.editor.setValue(unwrap(result.source));
-        if (result.hasOptOutput) {
+        if (result.optOutput) {
+            // result.hasOptOutput might be true for failed compilations
             this.optRemarks = result.optOutput;
             this.showOptRemarks();
         }

diff --git a/static/panes/stack-usage-view.ts b/static/panes/stack-usage-view.ts
@@ -88,9 +88,11 @@ export class StackUsage extends MonacoPane<monaco.editor.IStandaloneCodeEditor,
     override onCompileResult(id: number, compiler: CompilerInfo, result: CompilationResult) {
         if (this.compilerInfo.compilerId !== id || !this.isCompilerSupported) return;
         this.editor.setValue(unwrap(result.source));
-        if (result.hasStackUsageOutput) {
-            this.showStackUsageResults(unwrap(result.stackUsageOutput));
+        if (result.stackUsageOutput) {
+            // result.hasStackUsageOutput might be true for failed compilations
+            this.showStackUsageResults(result.stackUsageOutput);
         }
+
         // TODO: This is inelegant again. Previously took advantage of fourth argument for the compileResult event.
         const lang = compiler.lang === 'c++' ? 'cpp' : compiler.lang;
         const model = this.editor.getModel();