Fix glossary builder #2336
Fix glossary builder #2336
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
if we remove the generation function that uses this, do we still need it?
looks like it's still used for some tooltips via Tippy in the quicklooks, though that means we have to maintain data in two places, right?
There was a problem hiding this comment.
if we still want to use Tippy tooltips, it might be possible to have a naming convention for a glossary folder that has a bunch of .mdx files that we render in the tooltips based on the name of the file. I'd have to look a little closer at it.
There was a problem hiding this comment.
We wouldn't need the Notion doc anymore; However you raise a great point - if this impacts Tippy tooltips, we would need to workaround that. I was not aware of an impact between the two.
There was a problem hiding this comment.
We still use it, and it is still generated by website/src/scripts/build-glossary.ts. Do you think it answers your question, @douglance?
There was a problem hiding this comment.
ahhh we had two similar scripts. my mistake. ty sir!
This PR does a few things: