Skip to content

Conversation

@MishkaRogachev
Copy link
Contributor

Fixes NIT-4214
Pulls in OffchainLabs/nitro-precompile-interfaces#26

Changes:

  • Add GetMultiGasBaseFee precompile view to retrieve fees per resource kind
  • Improve TestMultiGasRefundForNormalTx to match exact price

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.92%. Comparing base (f14a0ee) to head (a31ed53).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4188       +/-   ##
===========================================
- Coverage   57.19%   34.92%   -22.27%     
===========================================
  Files         462      462               
  Lines       55938    55950       +12     
===========================================
- Hits        31991    19542    -12449     
- Misses      19143    32949    +13806     
+ Partials     4804     3459     -1345     

@MishkaRogachev MishkaRogachev force-pushed the add-multigas-base-fees-to-arbgasinfo branch from acc80e1 to 6f9042a Compare December 31, 2025 12:41
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
4466 9 4457 0
View the top 3 failed tests by shortest run time
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.130s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x19b
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 188
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
INFO [01-08|12:20:35.093] rpc response                             method=datastreaming_start logId=7  err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x695fa112\", \"0x33\", \"0xd9\", \"0x2a92\", \"0xa\", \"0xc4e3fe48fcac8ca3140c7ecea2e4dcecfa068d2df32b5571a3134896e6a7fa9b516376220e4c7d7d2b6af10599d144c9b3a9e7c2ce82496fb81bfbba0ffe1ed000\"]" errorData=null
    protocol_test.go:230: goroutine 276 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x161f510, 0xc0002ed880}, {0x1605d60, 0xc0002b2510}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x19b
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 188
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.13s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.170s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.17s)
TestArbOSVersion50
Stack Traces | 5.160s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestArbOSVersion50
=== CONT  TestArbOSVersion50
    precompile_inclusion_test.go:94: goroutine 681626 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4409930, 0xc04733b6c0}, {0x43c6060, 0xc1084b07e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/system_tests.Require(0xc04733b6c0, {0x43c6060, 0xc1084b07e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2034 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc04733b6c0, 0x32, {0xc0744bfe88, 0x3, 0x621a3c0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestArbOSVersion50(0xc04733b6c0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:75 +0x3ef
        testing.tRunner(0xc04733b6c0, 0x4044168)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestArbOSVersion50 (5.16s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@eljobe eljobe enabled auto-merge January 8, 2026 10:41
@eljobe eljobe added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2026
@eljobe eljobe added this pull request to the merge queue Jan 9, 2026
Merged via the queue into master with commit b0db211 Jan 9, 2026
24 checks passed
@eljobe eljobe deleted the add-multigas-base-fees-to-arbgasinfo branch January 9, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants