stylus params: only use one byte for MaxFragmentCount #4285

KolbyML · 2026-01-28T16:01:48Z

pulls in OffchainLabs/nitro-precompile-interfaces#31

codecov · 2026-01-28T16:20:50Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.68%. Comparing base (db29e55) to head (3604f83).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4285       +/-   ##
===========================================
- Coverage   57.12%   32.68%   -24.45%     
===========================================
  Files         476      476               
  Lines       56785    56785               
===========================================
- Hits        32441    18560    -13881     
- Misses      19506    34989    +15483     
+ Partials     4838     3236     -1602

github-actions · 2026-01-28T17:01:41Z

❌ 9 Tests Failed:

Tests completed	Failed	Passed	Skipped
4028	9	4019	0

View the top 3 failed tests by shortest run time

TestDataStreaming_PositiveScenario/Many_senders,_long_messages

Stack Traces | 0.180s run time

=== RUN   TestDataStreaming_PositiveScenario/Many_senders,_long_messages
WARN [01-28|17:39:20.032] Served datastreaming_start               conn=127.0.0.1:57322 reqid=260 duration="209.219µs" err="too much time has elapsed since request was signed"
INFO [01-28|17:39:20.042] rpc response                             method=datastreaming_start logId=276 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x697a49c7\", \"0x2e\", \"0xd9\", \"0x269f\", \"0xa\", \"0x3704a0a4c2dbcdb2281f792d497b0dc2ee604b9f94fadc4731c233165167e8c14b22eee7086acfd222cddcf75f7f33eac442ff49784f2fcda35b911e9920953200\"]" errorData=null
    protocol_test.go:230: goroutine 295 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x161f870, 0xc000601880}, {0x16060c0, 0xc00138a030}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x19b
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 266
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.18s)

TestDataStreaming_PositiveScenario

Stack Traces | 0.220s run time

=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.22s)

TestNitroNodeVersionAlerter

Stack Traces | 0.540s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-28|17:52:15.049] Batch overflow: compressed size limit exceeded compressedSize=247 limit=186 isHeader=false
INFO [01-28|17:52:15.049] Submitted transaction                    hash=0x65eed1911415d2be6ec2abc5eee7c9d734df24a9faf91ea7ab93eb8d0ef0db75 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=5   recipient=0x7E23C8862920797d81916d62c274dd9217113e28 value=1,000,000,000,000
INFO [01-28|17:52:15.050] Starting work on payload                 id=0x0312094fa60c2712
INFO [01-28|17:52:15.117] Deploying seq inbox
INFO [01-28|17:52:15.119] Updated payload                          id=0x0312094fa60c2712 number=57  hash=819680..05d7cc txs=1   withdrawals=0 gas=21000      fees=0.002098084723 root=5f0da6..c97735 elapsed=68.613ms
INFO [01-28|17:52:15.119] Stopping work on payload                 id=0x0312094fa60c2712 reason=delivery
INFO [01-28|17:52:15.120] Updated payload                          id=0x03fd7e95f2bb113d number=24  hash=9304e7..fd98c9 txs=1   withdrawals=0 gas=3,767,892  fees=3.767892e-06   root=a7fadf..98cd89 elapsed=71.390ms
INFO [01-28|17:52:15.120] Stopping work on payload                 id=0x03fd7e95f2bb113d reason=delivery
INFO [01-28|17:52:15.121] Imported new potential chain segment     number=57  hash=819680..05d7cc blocks=1  txs=1   mgas=0.021  elapsed=1.459ms     mgasps=14.387   triediffs=321.01KiB  triedirty=0.00B
INFO [01-28|17:52:15.121] Chain head was updated                   number=57  hash=819680..05d7cc root=5f0da6..c97735 elapsed="102.441µs"
INFO [01-28|17:52:15.122] Deploying seq inbox bufferable
INFO [01-28|17:52:15.124] Submitted transaction                    hash=0xcb830acfae2a5ed694cc2d6383498ddfc14b6b7441fdb1601bcbcba64fb558c4 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=27  recipient=0x4C4Ac1257945782bf52A724e75687d9010C770DE value=0
INFO [01-28|17:52:15.125] Batch overflow: compressed size limit exceeded compressedSize=247 limit=186 isHeader=false
INFO [01-28|17:52:15.126] Starting work on payload                 id=0x03c131de7b0f6d3e
INFO [01-28|17:52:15.127] Imported new potential chain segment     number=24  hash=9304e7..fd98c9 blocks=1  txs=1   mgas=3.768  elapsed=6.797ms     mgasps=554.307  triediffs=86.74KiB   triedirty=0.00B
INFO [01-28|17:52:15.127] Chain head was updated                   number=24  hash=9304e7..fd98c9 root=a7fadf..98cd89 elapsed="315.296µs"
INFO [01-28|17:52:15.134] Submitted transaction                    hash=0xbd2f29c35687cae65da518298f44d48bb07fb275667ffc8a5c416531b6691396 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=2   recipient=0x0000000000000000000000000000000000000071 value=1,000,000,000,000,000,000
INFO [01-28|17:52:15.135] Submitted contract creation              hash=0xabc91e94d0abb73979f5175c3bcc2149c53a59e786c5e1e9efcf0ed36f81ca88 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=3   contract=0xFE24a1d448a05c1d45C71dec3d218072dFBfA88b value=0
�[90mTime to activate storage: 147.556646ms�[0;0m
--- FAIL: TestNitroNodeVersionAlerter (0.54s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

bragaigor

LGTM

bragaigor · 2026-01-28T18:44:26Z

I guess you'll update contracts-local/src/precompiles submodule when OffchainLabs/nitro-precompile-interfaces#31 is in?

KolbyML · 2026-01-28T22:08:52Z

I guess you'll update contracts-local/src/precompiles submodule when OffchainLabs/nitro-precompile-interfaces#31 is in?

what do you mean? updating this PR's submodule pin? I think so, not sure what the process is for nitro-precompile-interfaces

bragaigor · 2026-01-28T22:17:17Z

what do you mean? updating this PR's submodule pin? I think so, not sure what the process is for nitro-precompile-interfaces

Yeah, I was under the assumption it was a similar process to updating go-ethereum, but I could be wrong

tsahee

LGTM

stylus params: only use one byte for MaxFragmentCount

97b1c2b

KolbyML added 2 commits January 28, 2026 10:15

update tests

618f2ef

Add change log

3604f83

KolbyML marked this pull request as ready for review January 28, 2026 17:58

KolbyML requested review from bragaigor, ganeshvanahalli and pmikolajczyk41 January 28, 2026 17:58

KolbyML assigned pmikolajczyk41 Jan 28, 2026

This was referenced Jan 28, 2026

stylus params: only use one byte for MaxFragmentCount OffchainLabs/nitro-precompile-interfaces#31

Merged

Increase Stylus smart contract size limit via merge-on-activate #4193

Merged

bragaigor approved these changes Jan 28, 2026

View reviewed changes

KolbyML assigned tsahee and unassigned pmikolajczyk41 Jan 28, 2026

KolbyML requested a review from tsahee January 28, 2026 22:09

tsahee approved these changes Jan 29, 2026

View reviewed changes

tsahee added the design-approved label Jan 29, 2026

tsahee enabled auto-merge January 29, 2026 02:24

tsahee added this pull request to the merge queue Jan 29, 2026

Merged via the queue into master with commit 178383c Jan 29, 2026
27 checks passed

tsahee deleted the stylus-params-only-use-one-byte-for-MaxFragmentCount branch January 29, 2026 03:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stylus params: only use one byte for MaxFragmentCount #4285

stylus params: only use one byte for MaxFragmentCount #4285

KolbyML commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

bragaigor left a comment

Uh oh!

bragaigor commented Jan 28, 2026

Uh oh!

KolbyML commented Jan 28, 2026

Uh oh!

bragaigor commented Jan 28, 2026 •

edited

Loading

Uh oh!

tsahee left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stylus params: only use one byte for MaxFragmentCount #4285

stylus params: only use one byte for MaxFragmentCount #4285

Conversation

KolbyML commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 9 Tests Failed:

Uh oh!

bragaigor left a comment

Choose a reason for hiding this comment

Uh oh!

bragaigor commented Jan 28, 2026

Uh oh!

KolbyML commented Jan 28, 2026

Uh oh!

bragaigor commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsahee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading

bragaigor commented Jan 28, 2026 •

edited

Loading