Minimize calls to storage for bytes/string #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rory Neithinger <rneithinger@offchainlabs.com>
rauljordan
reviewed
Feb 4, 2025
| if len < 32 { | ||
| while len < 32 { | ||
| if let Some(byte) = iter.next() { | ||
| root.word[len] = byte; |
There was a problem hiding this comment.
Do we need a bounds check here?
There was a problem hiding this comment.
It is not necessary because the while condition already ensures that len is smaller than the word size.
rauljordan
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Storage bytes and strings by reducing the number of calls to set_word and get_word. Now, when extending a storage bytes, the SDK will make a HostIO call for each chunk instead of each byte.
Close STY-207