-
Notifications
You must be signed in to change notification settings - Fork 862
Python sample added - Tab app navigation #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved !!!!. Kindly resolve the Copilot comments and include this sample in the main README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new Python sample demonstrating tab navigation in a Teams application, including backend, frontend, infrastructure, and CI configuration.
- Introduces Flask routes and template views for multiple tabs and a configuration page.
- Provides client-side setup script (
configure.js
) and CSS for styling. - Includes infrastructure (Bicep/ARM), CI workflow update, and VSCode task/launch configurations.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
samples/tab-app-navigation/python/app.py | Flask app with routes for tabs and configuration |
samples/tab-app-navigation/python/static/js/configure.js | Teams client configuration and save handler |
samples/tab-app-navigation/python/static/css/styles.css | Basic button and container styling |
samples/tab-app-navigation/python/config.py | DefaultConfig class reading environment variables |
samples/tab-app-navigation/python/README.md | Project documentation and setup instructions |
samples/tab-app-navigation/python/appManifest/manifest.json | Teams app manifest with tabs and domains |
samples/tab-app-navigation/python/.vscode/extensions.json | VSCode extension recommendations |
.github/workflows/build-complete-samples.yml | CI pipeline inclusion of this sample |
Comments suppressed due to low confidence (4)
samples/tab-app-navigation/python/README.md:18
- The README mentions "Built with Node.js" but this sample uses Python/Flask. Please update the text to reflect that it's a Python implementation.
Explore a sample Microsoft Teams application that showcases tab navigation capabilities, allowing users to seamlessly move between various tabs within the app. Built with Node.js, this example provides insights into creating intuitive navigation flows that enhance user engagement and improve overall app functionality.
samples/tab-app-navigation/python/appManifest/manifest.json:18
- The manifest description refers to Node.js, but this is a Python sample. Update the manifest text to mention Python instead.
"full": "This sample illustrates the tab navigation feature in a Microsoft Teams application, enabling smooth transitions between different tabs. Designed for use with Node.js, it highlights how users can effectively navigate within the app for an enhanced experience."
samples/tab-app-navigation/python/appManifest/manifest.json:46
- [nitpick] Inconsistent casing in the entityId "tab_One" versus "tab_two" and "tab_three". Consider using consistent lower-snake-case naming for all tabs.
"entityId": "tab_One",
samples/tab-app-navigation/python/.vscode/extensions.json:4
- Trailing comma in the JSON array will cause a parse error. Remove the extra comma after the last entry.
"ms-python.python",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some spell mistakes suggested by copilot please fix, Approving!
No description provided.