Nodejs changes for Branding Changes #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sample working Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AjayJ12-MSFT
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements several updates for branding changes in the Node.js samples by modernizing the OAuth token exchange flow and adapter setup while updating dependencies. Key changes include:
- Refactoring the SSO OAuth helper to use the CloudAdapter and the http-status-codes package.
- Revising index.js to streamline route definitions and upgrade the adapter setup.
- Updating package.json files to include new dependencies and remove duplicate entries.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/bot-join-team-using-qr-code/nodejs/ssoOauthHelpler.js | Refactored SSO OAuth token exchange flow and error handling. |
| samples/bot-join-team-using-qr-code/nodejs/index.js | Migrated to CloudAdapter, updated HTTP routing and error handling. |
| samples/bot-join-team-using-qr-code/nodejs/package.json | Added dependencies for http-status-codes and botframework-connector; cleaned duplicate entries. |
| samples/bot-join-team-using-qr-code/nodejs/RootBot.js | Introduced new RootBot for delegating messages based on channel. |
| samples/bot-ai-meeting-helper/package.json | Added dependencies for Microsoft Graph client and luxon. |
Files not reviewed (1)
- samples/bot-ai-meeting-helper/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
samples/bot-join-team-using-qr-code/nodejs/index.js:95
- [nitpick] Although the adapter's turnState is being explicitly set with the ConnectorClient and UserTokenClient, consider adding a clarifying comment to explain why this is necessary.
context.turnState.set(adapter.UserTokenClientKey, userTokenClient);
| @@ -1,4 +1,5 @@ | |||
| const { StatusCodes, ActivityTypes, tokenExchangeOperationName } = require('botbuilder'); | |||
| const { ActivityTypes, tokenExchangeOperationName } = require('botbuilder'); | |||
| const { StatusCodes } = require('http-status-codes'); | |||
|
|
|||
| class SsoOAuthHelpler { | |||
There was a problem hiding this comment.
The class name 'SsoOAuthHelpler' appears to contain a typo. Consider renaming it to 'SsoOAuthHelper' for clarity.
Suggested change
| class SsoOAuthHelpler { | |
| class SsoOAuthHelper { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.