-
Notifications
You must be signed in to change notification settings - Fork 861
Python Migration Bot Sequential Flow Adaptive Cards #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Migration Bot Sequential Flow Adaptive Cards #1687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new Python sample for a Teams bot demonstrating sequential workflows with adaptive cards.
Key changes:
- Introduce an
Incident
model with serialization, equality checks, and status validation. - Implement
BotSequentialFlowAdaptiveCard
for handling message/invoke activities and adaptive card interactions. - Provide project configuration, dependencies, Azure infra templates, and updated documentation.
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
samples/bot-sequential-flow-adaptive-cards/python/server/models/incident.py | Defines Incident class with equals , fill , to_dict , from_dict , and set_status methods |
samples/bot-sequential-flow-adaptive-cards/python/server/bots/botSequentialFlowAdaptiveCard.py | Implements TeamsActivityHandler subclass handling messaging extension and adaptive card flows |
samples/bot-sequential-flow-adaptive-cards/python/config.py | Reads bot credentials and port from environment into DefaultConfig |
samples/bot-sequential-flow-adaptive-cards/python/requirements.txt | Specifies runtime dependencies (requests , botbuilder-integration-aiohttp ) |
samples/bot-sequential-flow-adaptive-cards/python/README.md | Provides setup, usage instructions, and workflow diagrams |
Comments suppressed due to low confidence (2)
samples/bot-sequential-flow-adaptive-cards/python/server/models/incident.py:74
- New validation logic in
set_status
should have unit tests covering both valid and invalid status inputs to prevent regressions.
def set_status(self, status):
samples/bot-sequential-flow-adaptive-cards/python/server/models/incident.py:29
- The equals method calls
other.get_id()
(and similar getters) but no such getter methods are defined. Either implementget_<field>
methods or compare attributes directly (e.g.,other.id
).
self.id == other.get_id() and
samples/bot-sequential-flow-adaptive-cards/python/server/bots/botSequentialFlowAdaptiveCard.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Kindly add the build pipeline and include this sample in the main README file, and resolve the Copilot comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check all the spell mistakes and update.
No description provided.