[Do Not Review] Adding back in the deprecation pipeline #2684
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,68 @@ | ||||||
| trigger: none | ||||||
| resources: | ||||||
| repositories: | ||||||
| - repository: GovernedTemplates | ||||||
| type: git | ||||||
| name: OneBranch.Pipelines/GovernedTemplates | ||||||
| ref: refs/heads/main | ||||||
| pipelines: | ||||||
| - pipeline: microsoft-teams-library-js-pipeline | ||||||
| source: 'microsoft-teams-library-js/M365 Platform/App SDK/OfficeDev.microsoft-teams-library-js' | ||||||
| project: ISS | ||||||
| variables: | ||||||
| - name: System.Debug | ||||||
| value: true | ||||||
| extends: | ||||||
| template: v2/Microsoft.Official.yml@GovernedTemplates | ||||||
| parameters: | ||||||
| platform: | ||||||
| name: m365 | ||||||
| workload: Substrate | ||||||
| serviceTreeId: $(serviceTreeId) | ||||||
| serviceGroupName: Platform | ||||||
| stages: | ||||||
| - stage: Prod_Lockbox_Approval_Deployment | ||||||
| displayName: Lockbox Approval/Deployment | ||||||
| dependsOn: [] | ||||||
| variables: | ||||||
| stage_type: deployment | ||||||
| azure_subscription_ids: $(subscriptionId) | ||||||
| jobs: | ||||||
| - job: Agent_job | ||||||
| pool: | ||||||
| type: release | ||||||
| steps: | ||||||
| - download: microsoft-teams-library-js-pipeline | ||||||
| - task: prepare-deployment@1 | ||||||
| displayName: | ||||||
| inputs: | ||||||
| taskType: credentialFetchTaskAzureRM | ||||||
| armserviceconnection: $(serviceConnectionId) | ||||||
| subscriptionid: $(subscriptionId) | ||||||
| - task: AssetRetention@3 | ||||||
| displayName: ARtifact Retention Orchestrator Workflow (ARROW) | ||||||
| inputs: | ||||||
| ArrowServiceConnection: $(arrowServiceConnectionId) | ||||||
| IsShipped: true | ||||||
| - task: AzureKeyVault@2 | ||||||
| displayName: 'Azure Key Vault: $(keyVaultName)' | ||||||
| inputs: | ||||||
| ConnectedServiceName: $(serviceConnectionId) | ||||||
| KeyVaultName: $(keyVaultName) | ||||||
| SecretsFilter: $(keyVaultSecretsFilter) | ||||||
| - task: NodeTool@0 | ||||||
| displayName: Use Node 18.x | ||||||
| inputs: | ||||||
| versionSpec: 18.x | ||||||
| - task: PowerShell@2 | ||||||
| displayName: Update npmrc with NPM-TOKEN | ||||||
| inputs: | ||||||
| targetType: 'inline' | ||||||
| script: Set-Content -Path $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed/.npmrc -Value "//registry.npmjs.org/:_authToken=$(NPM-TOKEN)" | ||||||
| - task: Npm@1 | ||||||
| displayName: Publish to npm (tag beta) KV | ||||||
| inputs: | ||||||
| command: custom | ||||||
| workingDir: $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed | ||||||
| verbose: false | ||||||
| customCommand: deprecate @microsoft/teams-js@3.0.* "Package no longer supported. Use at your own risk" | ||||||
|
There was a problem hiding this comment. I feel like rather than needing to check in a PR each time you want to deprecate a version; it would make more sense to make the version a pipeline variable so we can edit it in ADO each time we run the pipeline.
Suggested change
There was a problem hiding this comment. Yup the plan was to make the version/versions plummed in as a pipeline resource instead of a single version. Only had it as the above since I was intending for this PR to actually just be a draft to see if it gets added to ADO correctly |
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you say more about how this pipeline works? This looks like every time the pipeline runs, it deprecates all 3.0.* packages. Is that how it's supposed to work? Or is the person who runs the pipeline supposed to be able to specify what version they want to deprecate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this was just meant to be a draft PR to see if the new pipeline would be added into ADO. Will be modifying this so that we can specify the version/versions we wish to deprecate as a Pipeline resource going forward.