migration

Oktawian-L · Nov 9, 2019 · 7f77f09 · 7f77f09
1 parent cc99f0b
commit 7f77f09
Show file tree

Hide file tree

Showing 8 changed files with 75 additions and 20 deletions.
diff --git a/SubitonAPI/SubitonAPI/Controllers/AuthController.cs b/SubitonAPI/SubitonAPI/Controllers/AuthController.cs
@@ -39,8 +39,11 @@ public AuthController(IAuthRepository repository, IConfiguration configuration)
         public async Task<ActionResult> Register(UserRegisterDTO userRegisterDTO)
         {
 
+            if (userRegisterDTO == null)
+                throw new ArgumentNullException(nameof(userRegisterDTO));
+
             userRegisterDTO.Username = userRegisterDTO.Username.ToLower();
-            if (await _repository.UserExists(userRegisterDTO.Username))
+            if (await _repository.UserExists(userRegisterDTO.Username).ConfigureAwait(false))
             {
                 return BadRequest("User already exixts");
             }

diff --git a/SubitonAPI/SubitonAPI/Controllers/PhotosController.cs b/SubitonAPI/SubitonAPI/Controllers/PhotosController.cs
@@ -10,20 +10,44 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Options;
 using SubitonAPI.Data;
+using SubitonAPI.DTO;
 using SubitonAPI.Helpers;
 using SubitonAPI.Models;
 
 namespace SubitonAPI.Controllers
 {
+    /// <summary>
+    /// Photo uploaded to claudinary
+    /// </summary>
+    /// <seealso cref="Microsoft.AspNetCore.Mvc.ControllerBase" />
     [Authorize]
     [Route("api/[controller]")]
     [ApiController]
     public class PhotosController : ControllerBase
     {
+        /// <summary>
+        /// Database context
+        /// </summary>
         private readonly DataContext _context;
+
+        /// <summary>
+        /// The user repository
+        /// </summary>
         private readonly IUserRepository _userRepository;
+
+        /// <summary>
+        /// The mapper
+        /// </summary>
         private readonly IMapper _mapper;
+
+        /// <summary>
+        /// The claudinary 
+        /// </summary>
         private readonly IOptions<ClaudinarySettings> _claudinarySettings;
+
+        /// <summary>
+        /// The cloudinary
+        /// </summary>
         private readonly Cloudinary _cloudinary;
 
         public PhotosController(DataContext context, IUserRepository userRepository, IMapper mapper, IOptions<ClaudinarySettings> claudinarySettings)
@@ -42,6 +66,20 @@ public PhotosController(DataContext context, IUserRepository userRepository, IMa
             _cloudinary = new Cloudinary(account);
         }
 
+        // POST: api/Photos
+        [HttpPost]
+        public async Task<ActionResult> AddPhotoForUser(int userId, PhotoCreateDTO photo)
+        {
+            _context.Photos.Add(photo);
+            await _context.SaveChangesAsync().ConfigureAwait(true);
+
+            if (photo == null)
+                throw new ArgumentNullException(nameof(photo));
+
+            return CreatedAtAction("GetPhoto", new { id = photo.Id }, photo);
+        }
+
+
         // GET: api/Photos
         [HttpGet]
         public async Task<ActionResult<IEnumerable<Photo>>> GetPhotos()
@@ -69,6 +107,10 @@ public async Task<ActionResult<Photo>> GetPhoto(int id)
         [HttpPut("{id}")]
         public async Task<IActionResult> PutPhoto(int id, Photo photo)
         {
+
+            if (photo == null)
+                throw new ArgumentNullException(nameof(photo));
+
             if (id != photo.Id)
             {
                 return BadRequest();
@@ -78,7 +120,7 @@ public async Task<IActionResult> PutPhoto(int id, Photo photo)
 
             try
             {
-                await _context.SaveChangesAsync().ConfigureAwait(true);
+                await _context.SaveChangesAsync().ConfigureAwait(false);
             }
             catch (DbUpdateConcurrencyException)
             {
@@ -95,17 +137,6 @@ public async Task<IActionResult> PutPhoto(int id, Photo photo)
             return NoContent();
         }
 
-        // POST: api/Photos
-        // To protect from overposting attacks, please enable the specific properties you want to bind to, for
-        // more details see https://aka.ms/RazorPagesCRUD.
-        [HttpPost]
-        public async Task<ActionResult<Photo>> PostPhoto(Photo photo)
-        {
-            _context.Photos.Add(photo);
-            await _context.SaveChangesAsync().ConfigureAwait(true);
-
-            return CreatedAtAction("GetPhoto", new { id = photo.Id }, photo);
-        }
 
         // DELETE: api/Photos/5
         [HttpDelete("{id}")]
@@ -118,7 +149,7 @@ public async Task<ActionResult<Photo>> DeletePhoto(int id)
             }
 
             _context.Photos.Remove(photo);
-            await _context.SaveChangesAsync();
+            await _context.SaveChangesAsync().ConfigureAwait(true);
 
             return photo;
         }

diff --git a/SubitonAPI/SubitonAPI/Controllers/ProfileController.cs b/SubitonAPI/SubitonAPI/Controllers/ProfileController.cs
@@ -25,7 +25,7 @@ public ProfileController(DataContext context)
         [HttpGet]
         public async Task<ActionResult<IEnumerable<User>>> GetUsers()
         {
-            return await _context.Users.ToListAsync();
+            return await _context.Users.ToListAsync().ConfigureAwait(false);
         }
 
         // GET: api/Users/5
@@ -97,7 +97,7 @@ public async Task<ActionResult<User>> DeleteUser(int id)
             }
 
             _context.Users.Remove(user);
-            await _context.SaveChangesAsync();
+            await _context.SaveChangesAsync().ConfigureAwait(false);
 
             return user;
         }

diff --git a/SubitonAPI/SubitonAPI/Controllers/UsersController.cs b/SubitonAPI/SubitonAPI/Controllers/UsersController.cs
@@ -36,7 +36,7 @@ public UsersController(IUserRepository userRepository, IMapper mapper)
         [HttpGet]
         public async Task<ActionResult<IEnumerable<User>>> GetUsers()
         {
-            var users = await _userRepository.GetAllUsers();
+            var users = await _userRepository.GetAllUsers().ConfigureAwait(false);
             // map from user to copllection dto
             var usersToReturn = _mapper.Map<IEnumerable<UserForDetailsDTO>>(users);
 
@@ -47,7 +47,7 @@ public async Task<ActionResult<IEnumerable<User>>> GetUsers()
         [HttpGet("{id}")]
         public async Task<ActionResult<User>> GetUser(int id)
         {
-            var user = await _userRepository.GetUser(id);
+            var user = await _userRepository.GetUser(id).ConfigureAwait(false);
 
             if (user == null)
             {
@@ -59,8 +59,6 @@ public async Task<ActionResult<User>> GetUser(int id)
 
 
         // PUT: api/Users/5
-        // To protect from overposting attacks, please enable the specific properties you want to bind to, for
-        // more details see https://aka.ms/RazorPagesCRUD.
         [HttpPut("{id}")]
         public async Task<IActionResult> PutUser(int id, UserUpdateDTO userUpdate)
         {

diff --git a/SubitonAPI/SubitonAPI/DTO/PhotoCreateDTO.cs b/SubitonAPI/SubitonAPI/DTO/PhotoCreateDTO.cs
@@ -0,0 +1,11 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+
+namespace SubitonAPI.DTO
+{
+    public class PhotoCreateDTO
+    {
+    }
+}
diff --git a/SubitonAPI/SubitonAPI/GlobalSuppressions.cs b/SubitonAPI/SubitonAPI/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "<Pending>", Scope = "member", Target = "~M:SubitonAPI.Migrations.extendPhotos.Down(Microsoft.EntityFrameworkCore.Migrations.MigrationBuilder)")]
diff --git a/SubitonAPI/SubitonAPI/Migrations/20191017170121_extendPhotos.cs b/SubitonAPI/SubitonAPI/Migrations/20191017170121_extendPhotos.cs
@@ -4,6 +4,7 @@ namespace SubitonAPI.Migrations
 {
     public partial class extendPhotos : Migration
     {
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "<Pending>")]
         protected override void Up(MigrationBuilder migrationBuilder)
         {
             migrationBuilder.AddColumn<int>(

diff --git a/SubitonAPI/SubitonAPI/Migrations/20191102214503_add_name.cs b/SubitonAPI/SubitonAPI/Migrations/20191102214503_add_name.cs
@@ -2,8 +2,12 @@
 
 namespace SubitonAPI.Migrations
 {
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>")]
+#pragma warning disable CA1707 // Identifiers should not contain underscores
     public partial class add_name : Migration
+#pragma warning restore CA1707 // Identifiers should not contain underscores
     {
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "<Pending>")]
         protected override void Up(MigrationBuilder migrationBuilder)
         {
             migrationBuilder.AddColumn<string>(
@@ -19,6 +23,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
 
         }
 
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "<Pending>")]
         protected override void Down(MigrationBuilder migrationBuilder)
         {
             migrationBuilder.DropColumn(