Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization develop to check npx #347

Merged

Conversation

MasoumehSheikhi
Copy link
Contributor

Title: Write a very short summary here

Problem: Write a description of your problem here.

Solution: Write a short summary of your solution.

Key Features:

  • Key feature 1
  • Key feature 2
  • ...

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, any questions you have, etc...

Consider linking any issues (#issue-number ) or adding @mentions to ensure specific people see it.

…ead_npx_zip function with withr::with_tempfile
…test_that "read NPX delim works - hashtags "#"" in tests for read_npx_delim
…ean_R4.3

Test CI with R 4.3.0

Windows CI failing because of known (apache/arrow#35594) issues between arrow and tzdb
…gnetteBuilder

Bug fix for "Note" in devtools::check()
…ternal_data

Optimization develop internal data
Merged because MacOS has issues with arrow lately.
…ltithreaded_tests

MacOS continues failing because of arrow, but everything else works like a charm.
@MasoumehSheikhi MasoumehSheikhi changed the title Optimization develop Optimization develop to check npx Apr 4, 2024
@MasoumehSheikhi MasoumehSheikhi merged commit 1fb9493 into optimization_develop_clean_check_npx Apr 4, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants