-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup data from inst extdata #349
Merged
klevdiamanti
merged 21 commits into
optimization_develop
from
optimization_develop_inst_extdata
Apr 17, 2024
Merged
Cleanup data from inst extdata #349
klevdiamanti
merged 21 commits into
optimization_develop
from
optimization_develop_inst_extdata
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Cleanup data from inst extdata
Problem: There were several datasets for testing purposes saved on inst/extdata.
Solution: We identified all the relveant datasets, and removed unnecessary ones.
Checklist
Type of changes
What type of changes does your code introduce?
Put an
x
in the boxes that applyFurther comments
We needed to create scripts which generate the preloaded datasets npx_data1, npx_data2 and manifest. We also handled a small bug in read_npx_wide with some NA values in the Uniprot.