Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup data from inst extdata #349

Merged
merged 21 commits into from
Apr 17, 2024

Conversation

klevdiamanti
Copy link
Contributor

Title: Cleanup data from inst extdata

Problem: There were several datasets for testing purposes saved on inst/extdata.

Solution: We identified all the relveant datasets, and removed unnecessary ones.

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • [ X Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (repo cleanup)

Further comments

We needed to create scripts which generate the preloaded datasets npx_data1, npx_data2 and manifest. We also handled a small bug in read_npx_wide with some NA values in the Uniprot.

@klevdiamanti klevdiamanti added the enhancement New feature or request label Apr 17, 2024
@klevdiamanti klevdiamanti merged commit 4270d6e into optimization_develop Apr 17, 2024
14 of 15 checks passed
@klevdiamanti klevdiamanti deleted the optimization_develop_inst_extdata branch April 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant