Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop 3.9.0 #417

Merged
merged 63 commits into from
Aug 6, 2024
Merged

Develop 3.9.0 #417

merged 63 commits into from
Aug 6, 2024

Conversation

kathy-nevola
Copy link
Contributor

Title: Write a very short summary here

Problem: Write a description of your problem here.

Solution: Write a short summary of your solution.

Key Features:

  • Key feature 1
  • Key feature 2
  • ...

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, any questions you have, etc...

Consider linking any issues (#issue-number ) or adding @mentions to ensure specific people see it.

kathy-nevola and others added 30 commits June 20, 2024 14:47
Add HT Bridging sample recommendations
Update instructions to write parquet file
Additional CSV support ( OA-2270 and OA-2151 )
Co-authored-by: Kathy Nevola <72228735+kathy-nevola@users.noreply.github.com>
Co-authored-by: Kathy Nevola <72228735+kathy-nevola@users.noreply.github.com>
dtopouza and others added 17 commits July 25, 2024 16:42
Changed regex for control assays to capture "control" and "CTRL" cases.

Co-authored-by: Kathy Nevola <72228735+kathy-nevola@users.noreply.github.com>
…. Add unit tests for this error. Update Olink_anova.R and Vignett.Rmd with documentation instructing users to remove internal and external controls before running ANOVA and ANOVA posthoc functions.
Add an error ANOVA functions when control assays are present
Update Description, News and Cran comments
@amrita-kar
Copy link
Contributor

amrita-kar commented Aug 1, 2024

All the newer added functions have the correct pipe '|>'. However parts of Olink_anova.R and Olink_boxplot.R still have %>%. Does this need to change to '|>'?

Does the above apply to the .Rd files for anova, anova_posthoc and boxplot?

@kathy-nevola kathy-nevola requested a review from amrita-kar August 2, 2024 14:34
@kathy-nevola kathy-nevola merged commit 8802c8d into main Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants