Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Count column check to cross-product bridge normalization #510

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

kristynchin-olink
Copy link
Contributor

@kristynchin-olink kristynchin-olink commented Feb 13, 2025

Add Count column check to cross-product bridge normalization

Problem: Provides error with informative text for cross-product bridging when the Count column is missing from either of or both of the datasets.

Solution: Add a check to internal function, norm_internal_cross_product, to ensure that the Count column is present in both dataframes in cross-product normalization.

Key Features:

  • Key feature 1: add check that Count column exists in both dataframes used in cross-product bridge normalization
  • Key feature 2: add unit test for norm_internal_cross_product to ensure that the error and corresponding text is functioning as expected

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

@klevdiamanti klevdiamanti self-requested a review February 14, 2025 12:43
@klevdiamanti klevdiamanti removed their request for review February 14, 2025 14:49
@klevdiamanti klevdiamanti added the enhancement New feature or request label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants